Create a History of the changes inside a Template Layout/ Use this Hi… #29752
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…story to calculate the changes on the receiver in a PP process
…pages-on-the-receiver
…receiver' of https://github.com/dotCMS/core into issue-29148-Modifying-the-Template-breaks-pages-on-the-receiver
…pages-on-the-receiver
jcastro-dotcms
approved these changes
Aug 28, 2024
dotCMS/src/main/java/com/dotmarketing/portlets/templates/design/bean/ContainerUUID.java
Outdated
Show resolved
Hide resolved
dotcms-integration/src/test/java/com/dotcms/datagen/TemplateLayoutDataGen.java
Outdated
Show resolved
Hide resolved
jdotcms
approved these changes
Aug 29, 2024
…receiver' of https://github.com/dotCMS/core into issue-29148-Modifying-the-Template-breaks-pages-on-the-receiver
…pages-on-the-receiver
victoralfaro-dotcms
approved these changes
Aug 29, 2024
|
freddyDOTCMS
deleted the
issue-29148-Modifying-the-Template-breaks-pages-on-the-receiver
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The problem here is that when you send a TemplateLayout after changed it to a receiver we don't have a way to know witch was the movement on the receiver because the UUID are already all recalculated, and the multi_tree are not sent unless you sent the page too.
The fix was create a new history on the layout to know how the UUID of each Container have been move, also I created a new version attribute to count how many time the Layout have changed.
Proposed Changes
https://github.com/dotCMS/core/pull/29752/files#diff-1e5a19fcdfdbe883752308cb7adf42231e860dff8300edf8b20c66f8b2b0fd39R168-R185
This method also recalculated the UUID.
https://github.com/dotCMS/core/pull/29752/files#diff-8a7533dd3f0219197b317cfcfc4848a3e61492c38f1bac1d5aeaec566025c626R50
https://github.com/dotCMS/core/pull/29752/files#diff-ce9702cf145c3dc3fd6472a323188b4897be3c98058272d8eba3f54d836f46ceR1433
https://github.com/dotCMS/core/pull/29752/files#diff-edc3e1981140c3dc84b3fbab35e5afb0ffc0e9f3f8b47673ed42da6939bf83fbR58
https://github.com/dotCMS/core/pull/29752/files#diff-ce9702cf145c3dc3fd6472a323188b4897be3c98058272d8eba3f54d836f46ceR1306
https://github.com/dotCMS/core/pull/29752/files#diff-ce9702cf145c3dc3fd6472a323188b4897be3c98058272d8eba3f54d836f46ceR1319
https://github.com/dotCMS/core/pull/29752/files#diff-acae9e18f11a2e8737fad0e31d65f09f2e330c049e6320996de89ed5ef495ef4R26
Checklist
Additional Info
** any additional useful context or info **
Screenshots
This PR fixes: #29148